feat (jkube-kit/config/service) : Add BuildPackBuildService (#2493) #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2448 (2024-02-05T16:50:45Z) ⚙️ JKube E2E Tests (7787834629)
|
rohanKanojia
force-pushed
the
pr/buildpacks-build-strategy
branch
from
bf8dec2 to
a1291ac
Compare
This is not small and simple. |
This comment was marked as outdated.
This comment was marked as outdated.
|
SonarCloud Quality Gate failed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2448 +/- ##
=============================================
+ Coverage 59.36% 70.32% +10.96%
- Complexity 4586 4971 +385
=============================================
Files 500 481 -19
Lines 21211 19349 -1862
Branches 2830 2499 -331
=============================================
+ Hits 12591 13608 +1017
+ Misses 7370 4513 -2857
+ Partials 1250 1228 -22 ☔ View full report in Codecov by Sentry. |
rohanKanojia
changed the title
rohanKanojia
force-pushed
the
pr/buildpacks-build-strategy
branch
2 times, most recently
from
5745971 to
96fc976
Compare
rohanKanojia
force-pushed
the
pr/buildpacks-build-strategy
branch
6 times, most recently
from
392d18e to
27fa035
Compare
manusa
reviewed
Feb 1, 2024
Comment on lines
77
to
89
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-jar-plugin</artifactId> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>test-jar</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> |
There was a problem hiding this comment.
No, looks like it's a leftover from previous approach I was trying
rohanKanojia
force-pushed
the
pr/buildpacks-build-strategy
branch
from
27fa035 to
bb3e6da
Compare
manusa
reviewed
Feb 1, 2024
| @@ -55,7 +55,7 @@ abstract class AbstractBuildPackCliDownloaderTest { | |||
| abstract String getProcessorArchitecture(); | |||
|
|
|||
| @BeforeEach | |||
| void setUp() { | |||
| void setUp() throws IOException { | |||
There was a problem hiding this comment.
I think this is also unneeded now
rohanKanojia
force-pushed
the
pr/buildpacks-build-strategy
branch
from
bb3e6da to
c06741e
Compare
rohanKanojia
force-pushed
the
pr/buildpacks-build-strategy
branch
from
c06741e to
4b5c0b2
Compare
Add TestHttpBuildPackArtifactsServer to host build pack download artifacts so that this test utility class can be reused in dependent modules Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/buildpacks-build-strategy
branch
from
4b5c0b2 to
a109c78
Compare
…jkube#2493) + Add new enum for buildpacks in JKubeBuildStrategy + Add BuildPackBuildService that would be activated when build strategy is set to buildpacks Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/buildpacks-build-strategy
branch
from
a109c78 to
47bcef0
Compare
Signed-off-by: Marc Nuri <[email protected]>
|
manusa
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #2465
Fixes #2493
buildpacksas new enum for buildpacks in JKubeBuildStrategyis set to buildpacks
Type of change
test, version modification, documentation, etc.)
Checklist