Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebAppGeneratorTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) #3286

Closed
1 task
rohanKanojia opened this issue Jul 31, 2024 · 1 comment · Fixed by #3302
Closed
1 task

WebAppGeneratorTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) #3286

rohanKanojia opened this issue Jul 31, 2024 · 1 comment · Fixed by #3302
Assignees
@ShivamChavan01
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.17.0

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

In the latest versions of Assertj asList() DSL method has been marked as deprecated:

jkube/jkube-kit/generator/webapp/src/test/java/org/eclipse/jkube/generator/webapp/WebAppGeneratorTest.java

Line 129 in e1cde0b

.extracting("inline.files").asList().extracting("destName")

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this.

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

  • asList() DSL method call is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class)) in all places
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 31, 2024
@ShivamChavan01
Copy link
Contributor

Hey @rohanKanojia Can i do it

ShivamChavan01 added a commit to ShivamChavan01/jkube that referenced this issue Jul 31, 2024
@ShivamChavan01
Fix eclipse-jkube#3286: Replace deprecated asList() with asInstanceOf…
c515daa 
… in WebAppGeneratorTest
@ShivamChavan01 ShivamChavan01 mentioned this issue Jul 31, 2024
Closed
17 tasks
ShivamChavan01 added a commit to ShivamChavan01/jkube that referenced this issue Aug 4, 2024
@ShivamChavan01
Issue eclipse-jkube#3286: Replace deprecated asList() in Web App Gene…
6dc353b 
…rator Test
@ShivamChavan01 ShivamChavan01 mentioned this issue Aug 4, 2024
Merged
17 tasks
@manusa manusa added this to the 1.17.0 milestone Aug 7, 2024 — with automated-tasks
manusa pushed a commit that referenced this issue Aug 7, 2024
@ShivamChavan01
fix: replace AssertJ's deprecated asList() DSL method in WebAppGenera…
4ff6ff6 
…torTest (3302)

Issue #3286: Replace deprecated asList() in Web App Generator Test
---
Removed the unused Imports
---
Used Only Imports which are required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShivamChavan01 ShivamChavan01

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.17.0
3 participants
@manusa @rohanKanojia @ShivamChavan01