Refactor IoUtil.getFreeRandomPort to always generate a valid free random port
#2501
Closed
1 task done
Comments
17 tasks
1 task
|
It looks like ConnectException is thrown by I added debug logs to see for which ports it's throwing BindException. While running test multiple times, I noticed it failed for a port On checking status of this port using netstat, it shows connection is already established. it : $ netstat -antup | grep 36266
(Not all processes could be identified, non-owned process info
will not be shown, you would have to be root to see it all.)
tcp 0 0 192.168.29.207:36266 198.252.206.25:443 ESTABLISHED 6017/firefox |
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Feb 8, 2024
…always generate a valid free random port (eclipse-jkube#2501) + Use ServerSocket to establish a connection instead of Socket which might also throw ConnectException for a socket already in use. + Modify IoUtilTes.findOpenPortWithSmallAttemptsCount to use `@RepeatedTest` annotation to run it 500 times Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Feb 8, 2024
…always generate a valid free random port (eclipse-jkube#2501) + Use ServerSocket to establish a connection instead of Socket which might also throw ConnectException for a socket already in use. + Modify IoUtilTes.findOpenPortWithSmallAttemptsCount to use `@RepeatedTest` annotation to run it 500 times Signed-off-by: Rohan Kumar <[email protected]>
17 tasks
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this issue
Feb 8, 2024
…always generate a valid free random port (eclipse-jkube#2501) + Use ServerSocket to establish a connection instead of Socket which might also throw ConnectException for a socket already in use. + Modify IoUtilTes.findOpenPortWithSmallAttemptsCount to use `@RepeatedTest` annotation to run it 500 times Signed-off-by: Rohan Kumar <[email protected]>
manusa
pushed a commit
that referenced
this issue
Feb 9, 2024
…always generate a valid free random port (#2501) + Use ServerSocket to establish a connection instead of Socket which might also throw ConnectException for a socket already in use. + Modify IoUtilTes.findOpenPortWithSmallAttemptsCount to use `@RepeatedTest` annotation to run it 500 times Signed-off-by: Rohan Kumar <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component
JKube Kit
Task description
Description
I noticed this while working on #2495
IoUtil.getFreeRandomPortseems to be generating already allocated ports. We often see these failures while running tests that involve TestHttpStaticServer (that uses this method to generate a free random port):Expected Behavior
Acceptance Criteria
IoUtil.getFreeRandomPortshould guarantee to generate a valid port even on multiple invocations.The text was updated successfully, but these errors were encountered: