-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jkube-kit/generator): Provide guidance when the final project packaged file is not found in Quarkus projects #2257
Comments
@rohanKanojia @sunix I'll work on this issue once I'm done with my current issues. I'll try to fix it by making changes in the parent of all generators. But If you have any other suggestions for this issue, do let me know. Thanks. |
How is this different from #2070 ? |
In #2257,
In the first case, there are no errors because mvn package was run at least once and mvn clean was not run afterwards, so old artifact will be there. So, the plugin won't give an error while trying to generate the build. Here, the plugin gives an error (because the user has not run mvn package even once, so there won't be any sourceFile / artifact to begin with). |
PR #2244 fixes this. |
Component
JKube Kit
Is your enhancement related to a problem? Please describe
If the user forgets to run mvn package before mvn k8s:build, the project artifact is not generated. The generator cannot find the artifact (for example quarkus-app directory in quarkus quickstart), so the plugin fails to generate a build through k8s:build.
Describe the solution you'd like
We should give a hint to the user that they may have forgotten to run mvn package.
Currently, the hint is given only in webapp quickstart. Now, we should do it for all generators.
Describe alternatives you've considered
No response
Additional context
Completes the fix initially #1408 that was done only for webapp generator and not Quarkus projects.
Acceptance Criteria
Scenario: Ensure users are guided to repackage their projects if the artifact is missing
Given:
When:
mvn oc:build oc:resource oc:apply
to deploy the application, encountering a missing package issue.Then:
Objective:
Ensure users receive a clear prompt to compile and package their applications before running the container image build task using the Kubernetes Maven Plugin within Quarkus projects.
The text was updated successfully, but these errors were encountered: