Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConcurrentModificationException when applying completion that adds import #1024

Open
datho7561 opened this issue Dec 5, 2024 · 1 comment
Open

ConcurrentModificationException when applying completion that adds import #1024

datho7561 opened this issue Dec 5, 2024 · 1 comment

Comments

@datho7561
Copy link

eg. open completion at | and accept StringBuilder

public class HelloWorld {
  public void main(String... args) {
    StringBuil|
  }
}
@datho7561
Copy link
Author

I realized that StringBuilder is in java.lang so it shouldn't even have an import being added, so I'll fix that first

@datho7561 datho7561 mentioned this issue Dec 5, 2024
Merged
datho7561 added a commit that referenced this issue Dec 6, 2024
@datho7561
Don't add import for java.lang
7f5c20a 
When importing a type via completion,
don't add an import for the type if it's from `java.lang`

A part of #1024

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this issue Dec 6, 2024
@datho7561 @mickaelistria
Don't add import for java.lang
7ac6e96 
When importing a type via completion,
don't add an import for the type if it's from `java.lang`

A part of #1024

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit that referenced this issue Dec 13, 2024
@datho7561
Don't add import for java.lang
ea9efc6 
When importing a type via completion,
don't add an import for the type if it's from `java.lang`

A part of #1024

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this issue Dec 15, 2024
@datho7561 @mickaelistria
Don't add import for java.lang
edfbdf6 
When importing a type via completion,
don't add an import for the type if it's from `java.lang`

A part of #1024

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this issue Jan 6, 2025
@datho7561 @mickaelistria
Don't add import for java.lang
eb784a9 
When importing a type via completion,
don't add an import for the type if it's from `java.lang`

A part of #1024

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this issue Jan 7, 2025
@datho7561 @mickaelistria
Don't add import for java.lang
236e199 
When importing a type via completion,
don't add an import for the type if it's from `java.lang`

A part of #1024

Signed-off-by: David Thompson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@datho7561