Remove code for Java pre 1.5 Java from bytecodeview

[akurtakov]

Checks were done based on compiler settings for the project and ECJ mandates 1.8 as a minimum now.

[akurtakov]

@iloveeclipse I would appreciate your review here.

[iloveeclipse]

@akurtakov : BCO shows compiled Java code also for class files no compiled in the ide but from jars. The bytecode there can be old one!

[eclipse-jdt-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.bcoview.feature/feature.xml
org.eclipse.jdt.bcoview/META-INF/MANIFEST.MF
org.eclipse.jdt.bcoview/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 0e57bf1f192defe3a06c576347799300cdbd739b Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <[email protected]>
Date: Sat, 21 Dec 2024 21:31:37 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/org.eclipse.jdt.bcoview.feature/feature.xml b/org.eclipse.jdt.bcoview.feature/feature.xml
index 0381b5cfe0..9b57be3a79 100644
--- a/org.eclipse.jdt.bcoview.feature/feature.xml
+++ b/org.eclipse.jdt.bcoview.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.jdt.bcoview.feature"
       label="Bytecode Outline View"
-      version="1.2.600.qualifier"
+      version="1.2.700.qualifier"
       provider-name="Eclipse.org"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
diff --git a/org.eclipse.jdt.bcoview/META-INF/MANIFEST.MF b/org.eclipse.jdt.bcoview/META-INF/MANIFEST.MF
index 70c4f8b728..a3b94900d9 100644
--- a/org.eclipse.jdt.bcoview/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.bcoview/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.bcoview;singleton:=true
-Bundle-Version: 1.2.600.qualifier
+Bundle-Version: 1.2.700.qualifier
 Bundle-ClassPath: .
 Bundle-Activator: org.eclipse.jdt.bcoview.BytecodeOutlinePlugin
 Bundle-Vendor: %providerName
diff --git a/org.eclipse.jdt.bcoview/pom.xml b/org.eclipse.jdt.bcoview/pom.xml
index 1d8ea8a140..6ae0839a03 100644
--- a/org.eclipse.jdt.bcoview/pom.xml
+++ b/org.eclipse.jdt.bcoview/pom.xml
@@ -18,7 +18,7 @@
   </parent>
   <groupId>org.eclipse.jdt</groupId>
   <artifactId>org.eclipse.jdt.bcoview</artifactId>
-  <version>1.2.600-SNAPSHOT</version>
+  <version>1.2.700-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
   
   <properties>
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

[iloveeclipse]

Unfortunately I don't have time this year to open IDE, so I can't verify if the code paths removed are only used for classes generated in workspace.

[akurtakov]

This can wait till after vacation. For whenever you come to it I know it can show code compiled outside of the ide but the removed code expliciltly relies on project compliance setting which can't be older than 1.8 now.

[akurtakov]

Part of #1685