Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different icon in "Rename to unnamed" #1836

Closed
Bananeweizen opened this issue Dec 5, 2024 · 0 comments · Fixed by #1838
Closed

Use different icon in "Rename to unnamed" #1836

Bananeweizen opened this issue Dec 5, 2024 · 0 comments · Fixed by #1838
Assignees
@jjohnstn
Labels
enhancement New feature or request
Milestone
4.35 M1

Comments

@Bananeweizen
Copy link
Contributor

From the 2024-12 presentation video:
image

The icon for the "Rename to unnamed variable" is the general "redo" icon, which I find confusing here. I'd rather suggest to use the same icon as further down below in "Rename in file" and "Rename in workspace".

See https://github.com/eclipse-jdt/eclipse.jdt.ui/blob/master/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/LocalCorrectionsSubProcessor.java#L992 for related code.
@jjohnstn jjohnstn self-assigned this Dec 5, 2024
@jjohnstn jjohnstn added the enhancement New feature or request label Dec 5, 2024
@jjohnstn jjohnstn added this to the 4.35 M1 milestone Dec 5, 2024
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Dec 5, 2024
@jjohnstn
Change the icon for rename to unnamed variable
9800b12 
- change icon for rename to unnamed variable to match rename in file
  icon
- fixes eclipse-jdt#1836
@jjohnstn jjohnstn mentioned this issue Dec 5, 2024
Merged
3 tasks
jjohnstn added a commit that referenced this issue Dec 5, 2024
@jjohnstn
Change the icon for rename to unnamed variable (#1838)
a5d69f1 
- change icon for rename to unnamed variable to match rename in file
  icon
- fixes #1836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjohnstn jjohnstn

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.35 M1
Development

Successfully merging a pull request may close this issue.

Change the icon for rename to unnamed variable jjohnstn/eclipse.jdt.ui-1
2 participants
@Bananeweizen @jjohnstn