Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/temurin #207

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix/temurin #207

merged 1 commit into from
Mar 22, 2023

Conversation

akurtakov
Copy link
Contributor

What it does

Switches Jenkins build JVM to Temurin so latest 17.x version is used.

How to test

Build still works

Author checklist

Needed so latest 17.x version is used as openjdk-jdk17-latest is stuck
at 17.0.2 and won't be updated by webmaster anymore.
@iloveeclipse
Copy link
Member

Switches Jenkins build JVM to Temurin so latest 17.x version is used.

Do we have problems with "old" Java 17 versions? If yes, which? If no, why should we change?

@akurtakov
Copy link
Contributor Author

Most notable reason to use 17.0.5 is https://bugs.openjdk.org/browse/JDK-8269039 which made some jars appear as unsigned late in the 4.27 cycle.

But even ignoring that using latest bugfix release should be the norm as these bugfix releases are what end users end up with (JustJ https://download.eclipse.org/justj/jres/17/downloads/latest/ in EPPs) so it's best to run verification with same bugfix level.

@iloveeclipse
Copy link
Member

Do you plan / do we need to change this overall in the platform / JDT / PDE / equinox too?

@akurtakov
Copy link
Contributor Author

akurtakov commented Mar 22, 2023

Do you plan / do we need to change this overall in the platform / JDT / PDE / equinox too?

Majority are already handled. git submodule foreach "git grep openjdk-jdk17-latest;true"|grep Jenkins gives 7 Jenkinsfiles. In general I handle them as I come to a repo for some reason but I would very welcome if someone wants to speed it up.

@iloveeclipse iloveeclipse merged commit 3d72f8c into eclipse-jdt:master Mar 22, 2023
@akurtakov akurtakov deleted the fix/temurin branch March 22, 2023 08:44
@iloveeclipse
Copy link
Member

Alex, if you have the list at hand, please post here, I will check that in context of eclipse-jdt/eclipse.jdt.core#883 & eclipse-jdt/eclipse.jdt.ui#493

@akurtakov
Copy link
Contributor Author

akurtakov commented Mar 22, 2023

'eclipse.jdt' -> Jenkinsfile: jdk 'openjdk-jdk17-latest'
'eclipse.jdt.debug' -> Jenkinsfile: jdk 'openjdk-jdk17-latest' Done by this patch
'eclipse.jdt.ui' -> Jenkinsfile: jdk 'openjdk-jdk17-latest'
'eclipse.platform' -> Jenkinsfile: jdk 'openjdk-jdk17-latest'
'eclipse.platform.swt' -> Jenkinsfile: jdk 'openjdk-jdk17-latest'
'eclipse.platform.swt.binaries' Jenkinsfile: withEnv(["JAVA_HOME=${ tool 'openjdk-jdk17-latest' }"]) {
'rt.equinox.p2' Jenkinsfile: jdk 'openjdk-jdk17-latest' Being worked on

iloveeclipse added a commit to iloveeclipse/eclipse.jdt.ui that referenced this pull request Apr 17, 2023
iloveeclipse added a commit to eclipse-jdt/eclipse.jdt.ui that referenced this pull request Apr 17, 2023
noopur2507 pushed a commit to eclipse-jdt/eclipse.jdt.ui that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants