Don't evaluate the same type twice when renaming a method

[fedejeanne]

Fixes eclipse-jdt/eclipse.jdt.ui#1945

[jukzi]

Theoretically the PR looks good, but unfortunatly ReferenceBinding may have unexpected hash/equals contract, see #3412. It might work to use a IdentityHashSet instead.

[fedejeanne]

IdentityHashSet is a test class and moving it to a production plugin might be an overkill. I emulated the behavior in the internal Wrapper class in my 2nd commit (which should be squashed before merging).

WDYT @jukzi ?

[jukzi]

IdentityHashSet is a test clas

use java.util.IdentityHashMap or org.eclipse.jdt.internal.compiler.lookup.ReferenceBindingSetWrapper

[fedejeanne]

Thank you for the hint! I used java.util.IdentityHashMap

[jukzi]

please find out if this code is executed by any test

[fedejeanne]

I found these:

• org.eclipse.jdt.core.tests.model.TypeHierarchyTests
• org.eclipse.jdt.ui.tests.core.TypeHierarchyTest
• org.eclipse.jdt.core.tests.model.TypeHierarchyNotificationTests

They run through the code, they run fast and they all pass.

There may be more (I stopped the search after these 3 findings).

[jukzi]

ok, org.eclipse.jdt.core.tests.model\workspace\TypeHierarchy\src\p2\I1.java is extended by both I3 and X, and Y extends both X and I3, which forms a type hierarchy with redundant superinterfaces.