BinaryTypeBinding: enrich RuntimeException with filename #3528
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is just for investigating #3516 and will be removed afterwards, I have no objections. If, however, this is intended to stay, wouldn't it be better to wrap the exception in or near BTB.cachePartsFrom()? That would benefit more scenarios, no? As for the exception message: it's not really the caching that creates problems, but loading the binary type does :) |
During internal errors it is not clear which file did contain the problematic binary. For example: eclipse-jdt#3516 Example output will be like: "java.lang.RuntimeException: RuntimeException loading =P/libGh375.jar|TestGh375.class"
jukzi
force-pushed
the
MatchLocator_RTE
branch
from
c7cf381 to
5914a7d
Compare
I would like to let it stay as similar error may appear in the future. I moved it to BTB as requested and changed the text to "loading". ok? |
jukzi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During internal errors it is not clear which file did contain the problematic binary. For example:
#3516
Example output will be like: "java.lang.RuntimeException: RuntimeException caching =P/libGh375.jar|TestGh375.class"