-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Restructure JDT core to get proper ecj bundle (#181)
The org.eclipse.jdt.core.ecj.validation was a "dummy" bundle so far, used only to validate compilation issues in IDE. That one is renamed (org.eclipse.jdt.core.ecj.validation -> org.eclipse.jdt.core.compiler.batch) and is a proper maven library now. It is actually the ecj compiler library without any dependencies (except optional ant), that could be consumed by JDT and the rest of the world. It must be required and re-exported by JDT core. Unfortunately, there are two split packages: - org.eclipse.jdt.internal.compiler - org.eclipse.jdt.internal.compiler.parser So the new bundle exports them to jdt.core and jdt.core re-exports. org.eclipse.jdt.compiler.apt and org.eclipse.jdt.compiler.tool were fragments of jdt.core, now they are inside org.eclipse.jdt.core.compiler.batch. TODO: 1) What I did NOT tried is to re-write all the magic scripts that build and package separated ecj library out of jdt.core. 2) The 3 antadapter classes are now split over ecj and jdt core, because BuildJarIndex.java and CheckDebugAttributes.java depend on JDT core code. 3) ecj.1 and build_ecj.xml aren't touched yet. ecj.1 was touched last time 2017, it seem to be used for man pages. 4) pom from jdt core will need an adoption. 5) org.eclipse.jdt-feature need to be updated 6) TBC See - #181 - eclipse-platform/eclipse.platform.ua#18
- Loading branch information
1 parent
71120c1
commit c4e7594
Showing
696 changed files
with
623 additions
and
1,570 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
org.eclipse.jdt.compiler.apt/.settings/org.eclipse.core.resources.prefs
This file was deleted.
Oops, something went wrong.
113 changes: 0 additions & 113 deletions
113
org.eclipse.jdt.compiler.apt/.settings/org.eclipse.jdt.core.prefs
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
15 changes: 0 additions & 15 deletions
15
org.eclipse.jdt.compiler.apt/compiler_apt_fragment.properties
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.