-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#220 require C++14 for iceoryx #390
Merged
elBoberido
merged 5 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#220-switch-to-C++14
Nov 25, 2020
Merged
iox-#220 require C++14 for iceoryx #390
elBoberido
merged 5 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#220-switch-to-C++14
Nov 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias Kraus <[email protected]>
… [[deprecated]] attribute Signed-off-by: Mathias Kraus <[email protected]>
marthtz
reviewed
Nov 23, 2020
Signed-off-by: Mathias Kraus <[email protected]>
elBoberido
force-pushed
the
iox-#220-switch-to-C++14
branch
from
November 23, 2020 15:19
1a3f212
to
0eda296
Compare
elBoberido
requested review from
orecham,
marthtz,
budrus,
MatthiasKillat,
mossmaurice and
dkroenke
November 23, 2020 15:41
elfenpiff
previously approved these changes
Nov 23, 2020
mossmaurice
reviewed
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use C++11, however we try to introduce C++14 as fast as possible
Could you update the CONTRIBUTING.md
?
You could also remove enable_if_t
from the iceoryx_utils/include/iceoryx_utils/cxx/type_trait.hpp
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
orecham
approved these changes
Nov 24, 2020
elfenpiff
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mathias Kraus [email protected]
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)Notes for Reviewer
Switch to C++14. This makes lambdas more convenient to use with
auto
and enablesif
andswitch
statements and loops in constexpr-declared functions.Additionally we can use the standard
[[deprecated]]
attribute instead of[[gnu::deprecated]]
https://en.wikipedia.org/wiki/C++14
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
Post-review Checklist for the Eclipse Committer
References