Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add containerization for samples w/ container documentation #64

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Add containerization for samples w/ container documentation #64

merged 7 commits into from
Nov 6, 2023

Conversation

devkelley
Copy link
Contributor

This PR adds the ability to containerize the Ibeji Samples:

  • Add dockerfiles for providers and consumers
  • Add mechanism to override configuration for all containerized services
  • Document how to containerize the samples
  • Add README's in the container folders and removed container documentation from main readme
  • Add DNS alias code to samples folder

container/README.md Outdated Show resolved Hide resolved
samples/container/README.md Outdated Show resolved Hide resolved
samples/common/src/utils.rs Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

samples/common/src/utils.rs Show resolved Hide resolved
ashbeitz
ashbeitz previously approved these changes Nov 3, 2023
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

jorchiu
jorchiu previously approved these changes Nov 3, 2023
@devkelley devkelley dismissed stale reviews from jorchiu and ashbeitz via c235a44 November 6, 2023 21:10
jorchiu
jorchiu previously approved these changes Nov 6, 2023
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Please take a look.

.github/workflows/rust-ci.yml Outdated Show resolved Hide resolved
.github/workflows/rust-ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ashbeitz ashbeitz merged commit 0e5e1ba into eclipse-ibeji:main Nov 6, 2023
10 of 12 checks passed
mobicatk pushed a commit to Mobica/EclipseSDV_ibeji that referenced this pull request Apr 24, 2024
…ibeji#64)

* Add containerization for samples w/ container documentation

* Fix fmt warnings

* fix linking issues

* Remove unecessary .to_string

* updated comment and readme wording

* Update rust ci

* Added -y
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants