Add container support for Ibeji #62
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ################################################################################ | ||
| # Create a stage for building the application. | ||
|
|
||
| ARG RUST_VERSION=1.72.1 |
There was a problem hiding this comment.
is there a way for this to be controlled by the rust-toolchain.toml file?
There was a problem hiding this comment.
Not in a simple way, there may be a way to copy the value from the rust-toolchain.toml file or install rust manually but I am not sure it is worth it at this point.
There was a problem hiding this comment.
If this goes in as is, then let's make it a high priority follow-up to address this. I have some ideas on how to do this. Perhaps we can have a 15 min brainstorming on the best way to do it and to make sure that the solution gets into all of our software components.
| ################################################################################ | ||
| # Create a stage for building the application. | ||
|
|
||
| ARG RUST_VERSION=1.72.1 |
There was a problem hiding this comment.
If this goes in as is, then let's make it a high priority follow-up to address this. I have some ideas on how to do this. Perhaps we can have a 15 min brainstorming on the best way to do it and to make sure that the solution gets into all of our software components.
core/common/src/utils.rs
Outdated
| #[cfg(feature = "containerize")] | ||
| let uri = { | ||
| // Container env variable names. | ||
| const HOST_GATEWAY_ENV_VAR: &str = "HOST_GATEWAY"; |
There was a problem hiding this comment.
Perhaps these constants should be moved out of this function (perhaps to s shared constant code file) and made public?
There was a problem hiding this comment.
So the idea was to keep the constants with this function because it is only used in a container, and those values should be set by the .env files provided
There was a problem hiding this comment.
If they are only ever used once, then they probably don't even need to be constants.
core/common/src/utils.rs
Outdated
| #[cfg(feature = "containerize")] | ||
| let uri = { | ||
| // Container env variable names. | ||
| const HOST_GATEWAY_ENV_VAR: &str = "HOST_GATEWAY"; |
There was a problem hiding this comment.
If they are only ever used once, then they probably don't even need to be constants.
* Add dockerfiles and supporting configuration to Ibeji * removed uncessary build dependencies * ignore devskim warnings * resolve README comments * fixed typo * set IBEJI_HOME environment variable in dockerfile * Update get_uri to return what env variable the failure was for * fix devskim err * attempt 2 of fixing devskim * change var name as ignoring creates a fmt error * remove commented feature flag * changed const to variables * fix feature flag * Rearrange README
This PR adds containerization support for Docker and Podman. In addition:
Additionally: