Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devkelley/standardize extension model #43

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Devkelley/standardize extension model #43

merged 4 commits into from
Sep 26, 2023

Conversation

devkelley
Copy link
Contributor

@devkelley devkelley commented Sep 21, 2023 •
edited
Loading

This PR refactors the extension library and converts the naming to 'Module'. In addition:

  • Makes each module a self contained library with its own Cargo.toml file. (core/module//*)
  • Adds a Grpc_Server object that assists with adding Modules and their interceptors to a builder and then building all the modules into a single server.
  • Moves the logic for adding modules with the feature flags to the main.rs file.
  • Moves 'load_settings' into the utils.rs file.

ashbeitz
ashbeitz reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments.

core/common/src/grpc_module.rs Show resolved Hide resolved
core/common/src/grpc_server.rs Outdated Show resolved Hide resolved
core/invehicle-digital-twin/src/main.rs Outdated Show resolved Hide resolved
core/invehicle-digital-twin/src/main.rs Outdated Show resolved Hide resolved
core/invehicle-digital-twin/src/main.rs Outdated Show resolved Hide resolved
core/module/managed_subscribe/src/managed_subscribe_ext.rs Outdated Show resolved Hide resolved
ashbeitz
ashbeitz approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ashbeitz ashbeitz merged commit a98c5eb into eclipse-ibeji:main Sep 26, 2023
mobicatk pushed a commit to Mobica/EclipseSDV_ibeji that referenced this pull request Apr 24, 2024
@devkelley
Devkelley/standardize extension model (eclipse-ibeji#43)
54e6987 
* Renamed extension to module, Restructured so each module has own Cargo.toml, Added GrpcServer

* Updated docs

* Updated comments

* change managed_subscribe_ext to managed_subscribe_module and removed extension from comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashbeitz ashbeitz ashbeitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devkelley @ashbeitz