Add streaming sample #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. ✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨ |
jorchiu
reviewed
Aug 23, 2023
jorchiu
approved these changes
Aug 23, 2023
wilyle
reviewed
Aug 23, 2023
|
|
||
| Steps: | ||
|
|
||
| 1. The best way to run the demo is by using three windows: one running the In-Vehicle Digital Twin, one running the Digital Twin Provider and one running the Digital Twin Consumer. |
There was a problem hiding this comment.
since much of the setup is copied and pasted for all of these demos, can we move it out into a "common setup" section?
There was a problem hiding this comment.
There are suttle differences and I expect these to diverge as Ibeji becomes more mature.
There was a problem hiding this comment.
Leaving as is for now.
ladatz
reviewed
Aug 24, 2023
wilyle
reviewed
Aug 25, 2023
ladatz
approved these changes
Aug 25, 2023
wilyle
reviewed
Aug 25, 2023
wilyle
approved these changes
Aug 25, 2023
mobicatk
pushed a commit
to Mobica/EclipseSDV_ibeji
that referenced
this pull request
Apr 24, 2024
* Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample * Render PlantUML files * Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample * Render PlantUML files * Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample * Render PlantUML files * Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample * Add streaming sample --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.