Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added seat massage demo #35

Merged
merged 22 commits into from
Jul 20, 2023
Merged

Added seat massage demo #35

merged 22 commits into from
Jul 20, 2023

Conversation

ashbeitz
Copy link
Contributor

No description provided.

digital-twin-model/dtdl/v3/content/hvac.json Outdated Show resolved Hide resolved
digital-twin-model/dtdl/v3/content/obd.json Outdated Show resolved Hide resolved
digital-twin-model/src/sdv_v1.rs Show resolved Hide resolved
samples/command/consumer/src/main.rs Show resolved Hide resolved
samples/mixed/consumer/src/main.rs Show resolved Hide resolved
samples/seat_massager/consumer/src/main.rs Outdated Show resolved Hide resolved
samples/seat_massager/consumer/src/main.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jorchiu jorchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments

samples/mixed/provider/src/provider_impl.rs Outdated Show resolved Hide resolved
samples/seat_massager/provider/src/provider_impl.rs Outdated Show resolved Hide resolved
samples/seat_massager/consumer/src/consumer_impl.rs Outdated Show resolved Hide resolved
samples/property/provider/src/main.rs Show resolved Hide resolved
samples/mixed/provider/src/provider_impl.rs Show resolved Hide resolved
@github-actions
Copy link
Contributor

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

docs/design/README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
docs/design/diagrams/findbyid_sequence.puml Outdated Show resolved Hide resolved
docs/design/diagrams/get_sequence.puml Outdated Show resolved Hide resolved
docs/design/diagrams/register_sequence.puml Outdated Show resolved Hide resolved
docs/design/diagrams/set_sequence.puml Outdated Show resolved Hide resolved
docs/design/diagrams/invoke_sequence.puml Show resolved Hide resolved
samples/mixed/provider/src/provider_impl.rs Show resolved Hide resolved
@@ -158,7 +189,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
let show_notification_command_provider_endpoint_info =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat: the repeated discover_digital_twin_provider_using_ibeji() can be reduced with partial!.
As well as the send_subscribe_request()

@ashbeitz ashbeitz merged commit bb500c8 into main Jul 20, 2023
@ashbeitz ashbeitz deleted the ashbeitz/seatMassageDemo branch July 20, 2023 22:34
mobicatk pushed a commit to Mobica/EclipseSDV_ibeji that referenced this pull request Apr 24, 2024
* Added seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Render PlantUML files

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Add seat massage demo

* Render PlantUML files

* Add seat massage demo

* Add seat massage demo

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants