Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust-toolchain.toml #34

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Add rust-toolchain.toml #34

merged 2 commits into from
Jun 29, 2023

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Jun 29, 2023

Adding a rust-toolchain.toml file will automatically manage the toolchain version when building projects in this repository. Because different ESDV components are using different toolchain files, this makes building multiple components side-by-side easier by avoiding the need to manually switch the current toolchain version

@@ -0,0 +1,2 @@
[toolchain]
channel = "nightly-2022-08-11"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why nightly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version was copied from the readme. I'm not sure exactly what requires the nightly build, @ashbeitz should be able to help

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ibeji has a basic DTDL Parser that uses a json-ld parser that has a dependency on the nightly build.

Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ashbeitz ashbeitz merged commit a2b4a85 into eclipse-ibeji:main Jun 29, 2023
mobicatk pushed a commit to Mobica/EclipseSDV_ibeji that referenced this pull request Apr 24, 2024
* add toolchain file

* add toml to approved words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants