New demo for dog mode props and cmds #18
Conversation
samples/mixed/consumer/src/main.rs
Outdated
|
|
||
| server_future.await?; | ||
|
|
||
| info!("The Consumer has conmpleted."); |
| tokio::spawn(async move { | ||
| let mut response_payload: String = format!("Successfully invoked {entity_id}"); | ||
|
|
||
| if entity_id == ACTIVATE_AIR_CONDITIOING { |
There was a problem hiding this comment.
There was a problem hiding this comment.
It has a compile time error, as match does not work with string slices.
Also, this is a personal preference thing. I'm leaving it as is.
|
|
||
| // Update the A/C's use of the battery. | ||
| if self.is_air_conditioning_active && self.hybrid_battery_remaining > 0.0 { | ||
| self.hybrid_battery_remaining -= 0.10; |
There was a problem hiding this comment.
maybe not deal with floats at all? why not used fixed-point values with 2 digits after the decimal point?
floats are unpredictable on different architectures
There was a problem hiding this comment.
how is this fixed? it is still a float.
There was a problem hiding this comment.
Yep, was looking at the outdated file. Apologies for the confusion. Ignore my previous comment.
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. ✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨ |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Some comments from previous iteration(s) have not been responded to. |
…moForDogModePropsAndCmds New demo for dog mode props and cmds
No description provided.