Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ashbeitz/add command support #17

Merged
merged 46 commits into from
Jan 31, 2023
Merged

Ashbeitz/add command support #17

merged 46 commits into from
Jan 31, 2023

Conversation

ashbeitz
Copy link
Contributor

No description provided.

@ashbeitz ashbeitz requested a review from fprezado January 24, 2023 21:35
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023 •
edited
Loading

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

sealemar
sealemar suggested changes Jan 25, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
dtdl-parser/src/object_info_impl.rs Show resolved Hide resolved
dtdl-parser/src/field_info_impl.rs Show resolved Hide resolved
samples/command/consumer/src/main.rs Show resolved Hide resolved
samples/command/consumer/src/main.rs Outdated Show resolved Hide resolved
samples/command/consumer/src/main.rs Show resolved Hide resolved
samples/command/consumer/src/main.rs Outdated Show resolved Hide resolved
samples/command/provider/src/provider_impl.rs Show resolved Hide resolved
samples/command/provider/src/provider_impl.rs Show resolved Hide resolved
wilyle
wilyle requested changes Jan 27, 2023
View reviewed changes
dtdl-parser/src/model_parser.rs Outdated Show resolved Hide resolved
dtdl-parser/src/model_parser.rs Outdated Show resolved Hide resolved
dtdl-parser/src/model_parser.rs Outdated Show resolved Hide resolved
dtdl-parser/src/model_parser.rs Outdated Show resolved Hide resolved
dtdl-parser/src/model_parser.rs Outdated Show resolved Hide resolved
dtdl-parser/src/model_parser.rs Outdated Show resolved Hide resolved
in-vehicle-digital-twin/src/digitaltwin_impl.rs Outdated Show resolved Hide resolved
samples/command/consumer/src/consumer_impl.rs Show resolved Hide resolved
samples/command/provider/src/provider_impl.rs Outdated Show resolved Hide resolved
samples/property/provider/src/provider_impl.rs Outdated Show resolved Hide resolved
@wilyle
Copy link
Contributor

wilyle commented Jan 27, 2023 •
edited
Loading

Apologies for any of my comments which got duplicated or are no longer relevant, the commits that came in while I was reviewing seem to have messed with the review interface even after I refreshed it and the ones I had already left had disappeared. I think I got rid of all of the ones that shouldn't be there

@ashbeitz ashbeitz merged commit 030cf17 into main Jan 31, 2023
@ashbeitz ashbeitz deleted the ashbeitz/addCommandSupport branch January 31, 2023 23:08
mobicatk pushed a commit to Mobica/EclipseSDV_ibeji that referenced this pull request Apr 24, 2024
@ashbeitz
Merge pull request eclipse-ibeji#17 from eclipse-ibeji/ashbeitz/addCo…
6895d47 
…mmandSupport

Ashbeitz/add command support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sealemar sealemar sealemar requested changes

@wilyle wilyle wilyle requested changes

@fprezado fprezado Awaiting requested review from fprezado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashbeitz @wilyle @sealemar