Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Quarkus 3.8 #3632

Merged
merged 2 commits into from
May 22, 2024
Merged

Update to Quarkus 3.8 #3632

merged 2 commits into from
May 22, 2024

Conversation

sophokles73
Copy link
Contributor

Also adapted some unit tests to reflect changes in Kafka and k8s client libraries.

@sophokles73
Copy link
Contributor Author

@calohmn with the update to Quarkus 3.8. the org.eclipse.hono.client.kafka.consumer.AsyncHandlingAutoCommitKafkaConsumerTest has started to fail. My assumption is that the behavior of the Kafka client used with Quarkus 3.8 has changed in comparison to Quarkus 3.2. I have tried to adapt accordingly but my understanding of our KafkaConsumer is limited. Would you mind taking a look what is going on?

@sophokles73 sophokles73 removed request for dejanb and kaniyan May 14, 2024 06:22
@calohmn
Copy link
Contributor

calohmn commented May 16, 2024

@sophokles73 Ok, I'll check.

@calohmn calohmn force-pushed the update_to_quarkus_3.8 branch from 2ef4b41 to 4c48480 Compare May 19, 2024 09:46
@calohmn
Copy link
Contributor

calohmn commented May 19, 2024

@sophokles73 Tests were failing with Kafka 3.6.1 because of changes to the MockConsumer.rebalance() method (see here).
Previously, the onPartitionsRevoked and onPartitionsAssigned handlers were not invoked there and we had used our own implementation in the Hono KafkaMockConsumer subclass.
The Hono implementation was mimicking the bahviour of the eager rebalance protocol, with the existing partitions being revoked first and then the new assignment getting applied.
The new MockConsumer.rebalance() implementation isn't doing that and is therefore mimicking the cooperative rebalance protocol.
Adding support for the old behaviour would require the use of reflection.
But since we are using cooperative rebalancing by default anyway (see #2908), I think it's better to concentrate on that.
I've adapted the tests accordingly.

@sophokles73 sophokles73 force-pushed the update_to_quarkus_3.8 branch 3 times, most recently from f12cab9 to 96a0f72 Compare May 19, 2024 16:09
bom/pom.xml Show resolved Hide resolved
sophokles73 and others added 2 commits May 22, 2024 07:56
Updated to Quarkus 3.8.4, adapted unit tests to reflect changes in
behavior of Kafka and k8s client libraries.
Tests were failing with Kafka 3.6.1 because of changes to
the MockConsumer.rebalance() method.
The rebalance-related tests have been changed to now
work with the MockConsumer.rebalance() method (removing the
Hono KafkaMockConsumer override of that method).
@sophokles73 sophokles73 force-pushed the update_to_quarkus_3.8 branch from 96a0f72 to 157836f Compare May 22, 2024 05:57
Copy link
Contributor

@calohmn calohmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophokles73 sophokles73 merged commit a5338a1 into master May 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants