Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust server startup to use autoassigned ports when not debuging #965

Closed
tortmayr opened this issue Mar 23, 2023 · 0 comments
Closed

Adjust server startup to use autoassigned ports when not debuging #965

tortmayr opened this issue Mar 23, 2023 · 0 comments
Assignees
@xai
Labels
client enhancement New feature or request theia vscode
Milestone
2.0.0 Release

Comments

@tortmayr
Copy link
Contributor

Both GLPS Server implementations are now capable of using port 0/auto port assignment and print the actual used port as part of the startup complete message.

We should update the server launchers in our integration projects to make use of these features. For normal startup (with embedded server processes) it doesn't make sense to use hardcoded ports instead we could use port 0 and let the server choose a free port.
This also avoids conflicts if multiple glsp servers are running at the same time.
Naturally, if the application is launched in debug/external server mode we still have to use a fixed port
@planger planger added this to the 2.0.0 Release milestone Mar 23, 2023
xai added a commit to xai/glsp-vscode-integration that referenced this issue Apr 5, 2023
@xai
feat: adjust server startup to use autoassigned ports
85ba3e0 
All our GLSP server implementations are now capable of port
autoassignment. The listening port is printed to STDOUT when the server
is launched and has to be parsed by clients.

This patch adjusts the vscode integration to use the new port
autoassignment.

Part of eclipse-glsp/glsp/issues/965

Signed-off-by: Olaf Lessenich <[email protected]>
xai added a commit to xai/glsp-theia-integration that referenced this issue Apr 5, 2023
@xai
feat: adjust server startup to use autoassigned ports
09782e2 
All our GLSP server implementations are now capable of port
autoassignment. The listening port is printed to STDOUT when the server
is launched and has to be parsed by clients.

This patch adjusts the Theia integration to use the new port
autoassignment.

Part of eclipse-glsp/glsp/issues/965

Signed-off-by: Olaf Lessenich <[email protected]>
This was referenced Apr 5, 2023
Merged
Merged
xai added a commit to xai/glsp-vscode-integration that referenced this issue Apr 5, 2023
@xai
feat: adjust server startup to use autoassigned ports
e90db66 
All our GLSP server implementations are now capable of port
autoassignment. The listening port is printed to STDOUT when the server
is launched and has to be parsed by clients.

This patch adjusts the vscode integration to use the new port
autoassignment.

Part of eclipse-glsp/glsp/issues/965

Signed-off-by: Olaf Lessenich <[email protected]>
This was referenced Apr 6, 2023
Merged
Merged
xai added a commit to xai/glsp-theia-integration that referenced this issue May 3, 2023
@xai
feat: adjust server startup to use autoassigned ports
cf232b4 
All our GLSP server implementations are now capable of port
autoassignment. The listening port is printed to STDOUT when the server
is launched and has to be parsed by clients.

This patch adjusts the Theia integration to use the new port
autoassignment.

Part of eclipse-glsp/glsp/issues/965

Signed-off-by: Olaf Lessenich <[email protected]>
tortmayr pushed a commit to eclipse-glsp/glsp-theia-integration that referenced this issue May 3, 2023
@xai
feat: adjust server startup to use autoassigned ports (#151)
887113e 
All our GLSP server implementations are now capable of port
autoassignment. The listening port is printed to STDOUT when the server
is launched and has to be parsed by clients.

This patch adjusts the Theia integration to use the new port
autoassignment.

Part of eclipse-glsp/glsp/issues/965

Signed-off-by: Olaf Lessenich <[email protected]>
@tortmayr tortmayr closed this as completed May 3, 2023
tortmayr pushed a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue May 4, 2023
@xai
feat: adjust server startup to use autoassigned ports (#33)
7c749d4 
All our GLSP server implementations are now capable of port
autoassignment. The listening port is printed to STDOUT when the server
is launched and has to be parsed by clients.

This patch adjusts the vscode integration to use the new port
autoassignment.

Part of eclipse-glsp/glsp/issues/965

Signed-off-by: Olaf Lessenich <[email protected]>
hege088 pushed a commit to hege088/glsp-vscode-integration that referenced this issue Feb 2, 2024
@xai @hege088
feat: adjust server startup to use autoassigned ports (eclipse-glsp#33)
b191d58 
All our GLSP server implementations are now capable of port
autoassignment. The listening port is printed to STDOUT when the server
is launched and has to be parsed by clients.

This patch adjusts the vscode integration to use the new port
autoassignment.

Part of eclipse-glsp/glsp/issues/965

Signed-off-by: Olaf Lessenich <[email protected]>

(cherry picked from commit 7c749d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xai xai

Labels
client enhancement New feature or request theia vscode
Projects
None yet
Milestone
2.0.0 Release
Development

No branches or pull requests
3 participants
@planger @xai @tortmayr