Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example build (WebPack & Server download) #30

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Fix example build (WebPack & Server download) #30

merged 1 commit into from
Dec 19, 2022

Conversation

debovema
Copy link
Contributor

It seems that #29 introduced some regressions:

  • the WebPack build is no longer called, hence the webview.js is not created and copied into extension/pack directory
  • the prebuild GLSP example server is no longer downloaded during the extension build (which is better I think): I added an instruction in the README to download it manually

@tortmayr tortmayr self-requested a review December 19, 2022 14:13
tortmayr
tortmayr approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Changes look good to me.

@tortmayr tortmayr merged commit 0c604ff into eclipse-glsp:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debovema @tortmayr