GLSP-1266 Fix handling of zero values in builder functions #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
requested changes
Feb 21, 2024
- Fix handling of zero values in GBoundsAwareBuilder functions - Fix handling of zero values in GAlignableBuilder function Resolves eclipse-glsp/glsp/issues/1266
ndoschek
force-pushed
the
issues/1266
branch
from
5ba0a10 to
4cf2218
Compare
ndoschek
changed the title
|
Sure, thanks for the review @tortmayr! |
|
I found some motivation and added a few unit tests for the functions I updated, would be great if you could have a quick look on those as well when you get a chance. Thanks! |
tortmayr
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
GBoundsAwareBuilderfunctionsGAlignableBuilderfunctionResolves eclipse-glsp/glsp/issues/1266
Changelog