Support async command execution #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change command API to support MaybePromise<void> instead of just plain voids. This enables async command execution e.g. for communicating with a modelserver Contributed on behalf of STMicroelectronics
martin-fleck-at
requested changes
Feb 28, 2023
| @@ -108,12 +110,14 @@ export class CompoundCommand implements Command { | |||
| const alreadyRedone: Command[] = []; | |||
|
|
|||
| try { | |||
| this.commands.forEach(command => { | |||
| for (const command of this.commands) { | |||
There was a problem hiding this comment.
Should we not also await the redo in the line below to make sure that the order is properly kept and there are no conflicts?
| } catch (err) { | ||
| alreadyRedone.forEach(command => command.undo()); | ||
| for (const command of alreadyRedone) { | ||
| command.undo(); |
There was a problem hiding this comment.
Should we not also await the undo here to make sure that the order is properly kept and there are no problems?
tortmayr
requested review from
martin-fleck-at
and removed request for
planger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change command API to support
MaybePromise<void>instead of just plain voids. This enables async command execution e.g. for communicating with a modelserverContributed on behalf of STMicroelectronics