Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling of repo script #20

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Improve error handling of repo script #20

merged 1 commit into from
Aug 8, 2024

Conversation

haydar-metin
Copy link
Contributor

What it does

Closes eclipse-glsp/glsp#1382

How to test

write yarn repo client clone twice
second time should fail with status 1

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

planger
planger approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@planger planger merged commit c3db6e0 into eclipse-glsp:main Aug 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Playwright] Improve error handling of repo script
2 participants
@haydar-metin @planger