#94 #104 #96 Clean up communication protocol #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean up communication and move implementation into glsp client - Define a "clean" `GLSPClient` interface that is independent from the underlying communication protocol - Provide a base implementation for a jsonrpc-based `GLSPClient` - Update dependencies to sprotty 0.9.0 - Align dependency versions with Theia versions - Add new DisposeClientAction to notify the server if a specific diagram client/widget can be disposed (e.g. on editor tab close) Part of: - eclipse-glsp/glsp/issues/104 - eclipse-glsp/glsp/issues/94 - eclipse-glsp/glsp/issues/96
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Aug 24, 2020
- Remove deprecated glsp client protcol and reuse the new API provided by @eclipse-glsp/client (#94 #96) - Update dependencies to align with sprotty 0.9.0 and Theia 1.3.0. (104) - Refactor glsp contributions to avoid dependencies on the (now deprecated) @theia/language module (#105) - Provide a dedicated TheiaGLSPClient that uses the MessageService to propagate connection errors. (#39) - Use unique application id in widgetId. Requires: eclipse-glsp/glsp-client/pull/79 Part of: - eclipse-glsp/glsp/issues/104 - eclipse-glsp/glsp/issues/94 - eclipse-glsp/glsp/issues/96 - eclipse-glsp/glsp/issues/105 - eclipse-glsp/glsp/issues/39
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Aug 24, 2020
- Remove deprecated glsp client protcol and reuse the new API provided by @eclipse-glsp/client (#94 #96) - Update dependencies to align with sprotty 0.9.0 and Theia 1.3.0. (104) - Refactor glsp contributions to avoid dependencies on the (now deprecated) @theia/language module (#105) - Provide a dedicated TheiaGLSPClient that uses the MessageService to propagate connection errors. (#39) - Use unique application id in widgetId. Requires: eclipse-glsp/glsp-client/pull/79 Part of: - eclipse-glsp/glsp/issues/104 - eclipse-glsp/glsp/issues/94 - eclipse-glsp/glsp/issues/96 - eclipse-glsp/glsp/issues/105 - eclipse-glsp/glsp/issues/39
planger
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Great work, thanks a lot!
I've appended a few minor changes in a separate commit for your review. Other than that, this looks great!
Just a general remark regarding copyrights, please keep the original where applicable but just update the year (e.g. original 2019 --> now 2019 - 2020). The copyright owner should remain the same.
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Aug 25, 2020
#44) * #105 #104 #96 #94 #39 Cleanup and refactor client-server communication - Remove deprecated glsp client protcol and reuse the new API provided by @eclipse-glsp/client (#94 #96) - Update dependencies to align with sprotty 0.9.0 and Theia 1.3.0. (104) - Refactor glsp contributions to avoid dependencies on the (now deprecated) @theia/language module (#105) - Provide a dedicated TheiaGLSPClient that uses the MessageService to propagate connection errors. (#39) - Use unique application id in widgetId. Requires: eclipse-glsp/glsp-client/pull/79 Part of: - eclipse-glsp/glsp/issues/104 - eclipse-glsp/glsp/issues/94 - eclipse-glsp/glsp/issues/96 - eclipse-glsp/glsp/issues/105 - eclipse-glsp/glsp/issues/39 * Fix minors and remove dep to @theia/languages Co-authored-by: Philip Langer <[email protected]>
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
…on protocol (eclipse-glsp#79) * eclipse-glsp#94 eclipse-glsp#104 eclipse-glsp#96 Clean up communication protocol - Clean up communication and move implementation into glsp client - Define a "clean" `GLSPClient` interface that is independent from the underlying communication protocol - Provide a base implementation for a jsonrpc-based `GLSPClient` - Update dependencies to sprotty 0.9.0 - Align dependency versions with Theia versions - Add new DisposeClientAction to notify the server if a specific diagram client/widget can be disposed (e.g. on editor tab close) Part of: - eclipse-glsp/glsp/issues/104 - eclipse-glsp/glsp/issues/94 - eclipse-glsp/glsp/issues/96 * Fix minors * Adapt copyright headers Co-authored-by: Philip Langer <[email protected]>
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
…on protocol (eclipse-glsp#79) * eclipse-glsp#94 eclipse-glsp#104 eclipse-glsp#96 Clean up communication protocol - Clean up communication and move implementation into glsp client - Define a "clean" `GLSPClient` interface that is independent from the underlying communication protocol - Provide a base implementation for a jsonrpc-based `GLSPClient` - Update dependencies to sprotty 0.9.0 - Align dependency versions with Theia versions - Add new DisposeClientAction to notify the server if a specific diagram client/widget can be disposed (e.g. on editor tab close) Part of: - eclipse-glsp/glsp/issues/104 - eclipse-glsp/glsp/issues/94 - eclipse-glsp/glsp/issues/96 * Fix minors * Adapt copyright headers Co-authored-by: Philip Langer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLSPClientinterface that is independent from the underlying communication protocolGLSPClientPart of: