Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case of SAMM model elements generated from AAS #682

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Dec 6, 2024

Description

When creating Aspect Models from AAS, use the case according to the naming rules.

Fixes #676

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Additional notes:

This PR introduces the IDTA submodels repository as a git submodule in the
esmf-aspect-model-aas-generator/src/test/resources directory, so that systematic
translation tests can be done based on the original sources.

Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit 14d5b45 into eclipse-esmf:main Dec 9, 2024
4 checks passed
@atextor atextor deleted the 676-generate-valid-identifiers-from-aas-idshort branch December 9, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AASX2SAMM generator should generate valid aspect model: naming convention violated
2 participants