-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generation of JSON sample payload #674
Merged
atextor
merged 29 commits into
eclipse-esmf:main
from
bci-oss:669-invalid-attribute-in-sample-json-payload
Nov 8, 2024
Merged
Fix generation of JSON sample payload #674
atextor
merged 29 commits into
eclipse-esmf:main
from
bci-oss:669-invalid-attribute-in-sample-json-payload
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I.e., have it inherit from Generator and use the same configuration approach as the other generators
org.eclipse.esmf.aspectmodel.generator.Generator already fulfills this task
Yauhenikapl
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It's already configured in the 'native' profile
Release v2.9.8 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JSON sample payload generation sometimes includes a
@type
attribute that isintentionally added to enable Jackson parsing JSON when Entity inheritance is
used. However, this is not valid according to the specification. This PR
therefore makes adding
@type
configurable with "off" being the default; inaddition it is possible to control the
JsonTypeInfo
annotation that isinserted in generated Java classes; with the default now changed from NAME to
DEDUCTED (which works without
@type
in many cases), but it is changeable (inJava API/Maven Plugin/samm-cli).
Fixes #669
Type of change
Please delete options that are not relevant.
Checklist: