Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --version switch #671

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Nov 6, 2024


Description

The --version switch crashes samm-cli due to a missing resource, this PR fixed it.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Due to the test setup with the SecurityManager that captures System.exit(), the
actual result code can not reliably be passed to the test when System.exit() is
called outside a command
@atextor atextor merged commit 5797b71 into eclipse-esmf:main Nov 7, 2024
4 checks passed
@atextor atextor deleted the fix-version-switch branch November 7, 2024 08:11
Copy link

Release v2.9.8 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants