Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.graalvm.js:js dependency is missing in the fat jar #670

Conversation

Yauhenikapl
Copy link
Contributor

Description

Add org.graalvm.js:js dependency is missing in the fat jar

Fixes #663

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Additional notes

@Yauhenikapl Yauhenikapl requested review from atextor and MelleD November 4, 2024 08:50
@Yauhenikapl Yauhenikapl merged commit 87be831 into eclipse-esmf:main Nov 5, 2024
4 checks passed
@Yauhenikapl Yauhenikapl deleted the bugfix/663-samm-validate-not-working-with-samm-cli-on-macos branch November 5, 2024 08:27
Copy link

github-actions bot commented Nov 6, 2024

Release v2.9.7 addresses this.

1 similar comment
Copy link

github-actions bot commented Nov 7, 2024

Release v2.9.7 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] samm validate not working with samm-cli 2.9.6 on MacOS
3 participants