Migrate all validation related imports to Jakarta #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -839,8 +839,8 @@ public void testEnumComplexMapping( final KnownVersion metaModelVersion ) { | |||
| + "['properties']['description']['enum'][0]" ) ).isEqualTo( "Result succeeded" ); | |||
| assertThat( context.<String> read( "$['components']['schemas']['ResultGood']['properties']['details']" | |||
| + "['properties']['message']['enum'][0]" ) ).isEqualTo( "Evaluation succeeded." ); | |||
| assertThat( context.<Double> read( "$['components']['schemas']['ResultGood']['properties']['details']" | |||
| + "['properties']['numericCode']['enum'][0]" ) ).isCloseTo( 10.0d, Percentage.withPercentage( 1.0d ) ); | |||
| assertThat( context.<Integer> read( "$['components']['schemas']['ResultGood']['properties']['details']" | |||
There was a problem hiding this comment.
Not sure myself about this one. I wondered how this ever worked, because it was never a float/double value.
There was a problem hiding this comment.
Yes, the same question)
you are totally right..)
I found, that the build pipelines every time working like we expect, but in my local env I was getting this error...
But I did the same fix in my PR - #441
atextor
force-pushed
the
feature/migrate-to-jakarta
branch
from
9b4a652 to
f6e2b13
Compare
|
Rebased to main |
atextor
approved these changes
Oct 19, 2023
Yauhenikapl
approved these changes
Oct 19, 2023
|
Release v2.4.0 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455