Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Conceptual improvements for namespace #425

Conversation

Yauhenikapl
Copy link
Contributor

@Yauhenikapl Yauhenikapl commented Sep 19, 2023

Changes:

  • Update basic code for supporting new Entity - Namespace after release meta-model version 2.2.0.

Fixes #450

Changes:
- Update basic code for adding new Entitty after release meta-model version 2.2.0.
@Yauhenikapl Yauhenikapl force-pushed the 10898-Conceptual_improvements_for_namespaces branch from 56788c9 to c110836 Compare September 19, 2023 07:11
@Yauhenikapl Yauhenikapl force-pushed the 10898-Conceptual_improvements_for_namespaces branch from 28da46d to 46dee7c Compare September 20, 2023 06:51
*
* @since SAMM 2.2.0
*/
public interface Namespace extends StructureElement {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not extends StructureElement; since it does not have Properties like Aspects and Entities.

@@ -142,6 +142,8 @@ ImmutableList.<String> builder().addAll( queryFilesForAllMetaModelVersions )
.addAll( queryFilesForMetaModelVersionsAsOf2_0_0 )
.build() );

//TODO: Add new version of SAMM 2.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be necessary if #407 is merged before.

@chris-volk chris-volk changed the title feature: Conceptial improvements for namespace feature: Conceptual improvements for namespace Oct 17, 2023
@Yauhenikapl
Copy link
Contributor Author

I was done in the separate task: #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Implement support for samm:Namespace
2 participants