Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SAMM-CLI aas generation: aas:ConceptDescription for samm:Property gets aas:idShort based on samm:Characteristic.name #457

Closed
mhmmi opened this issue Oct 19, 2023 · 3 comments · Fixed by #483
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. bug Something isn't working

Comments

@mhmmi
Copy link

mhmmi commented Oct 19, 2023

Describe the bug
When creating AAS files with SAMM-CLI: An aas:ConceptDescription for a samm:Property gets an aas:idShort based on its samm:Characteristic.name instead of the samm:Property. The same applies to the aas:displayName. While this is not explicitly defined in https://eclipse-esmf.github.io/esmf-developer-guide/tooling-guide/java-aspect-tooling.html#mapping-aas, I think it's wrong, as the aas:ConceptDescription describes the aas:Property (or aas:SubmodelElement in general). In particular, this creates ambiguous aas:idShorts when a samm:Characteristic is used multiple times.

Where
When creating AAS files with SAMM-CLI

Screenshots
-/-

Additional context
-/-

@mhmmi mhmmi added the bug Something isn't working label Oct 19, 2023
@chris-volk
Copy link
Contributor

Dear @mhmmi , thanks for taking the time to provide this and the other bug reports.

@chris-volk chris-volk added the acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. label Oct 24, 2023
Yauhenikapl added a commit to bci-oss/esmf-sdk that referenced this issue Oct 27, 2023
…property name

Changes:
- Provide id_short of Property name to ConceptDescription;
- Provide Property displayName to ConceptDescription;
- Fix tests.

Fixes eclipse-esmf#457
Yauhenikapl added a commit to bci-oss/esmf-sdk that referenced this issue Nov 24, 2023
…property name

Changes:

- Provide id_short of Property name to ConceptDescription;
- Provide Property displayName to ConceptDescription;
- Fix tests.

Fixes eclipse-esmf#457
@chris-volk chris-volk reopened this Nov 28, 2023
@chris-volk
Copy link
Contributor

Mapping improvements from Property(/Characteristic) to ConceptDescription will be considered together with #434

@Yauhenikapl
Copy link
Contributor

Hi,

After some discussion with @BirgitBoss @chris-volk @atextor @KobOp we agreed with this PR: SAMM-CLI aas generation

NOTE:
The source of a ConceptDescription is only a Property and not a Characteristic since as of Dec 2023 ConceptDescriptions are 'only' properties as in IEC61360.

Thanks,
Best Regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants