Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Use MADR to document important past design decisions #69

Closed
atextor opened this issue Jul 18, 2023 · 0 comments
Closed

[Task] Use MADR to document important past design decisions #69

atextor opened this issue Jul 18, 2023 · 0 comments
Assignees
@michelu89
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps.

Comments

@atextor
Copy link
Contributor

atextor commented Jul 18, 2023

Is your task related to a problem? Please describe.
In #61, the infrastructure for Architecture Decision Records was added. This should be used to make explicit important design decisions that were taken in the past.

Describe the solution you'd like
Seperate ADRs at least for the topics:

  • Usage of Electron
  • Separation into frontend and backend
  • Usage of MxGraph, N3

Additional context
See also eclipse-esmf/esmf-semantic-aspect-meta-model#242, eclipse-esmf/esmf-sdk#391
This was referenced Jul 18, 2023
Closed
Closed
@chris-volk chris-volk added the acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. label Jul 25, 2023
michelu89 added a commit to bci-oss/esmf-aspect-model-editor that referenced this issue Sep 27, 2023
@michelu89
Fix several bugs
4a5566b 
* increase performance of loading large model eclipse-esmf#77
* eclipse-esmf#78
* eclipse-esmf#69
* Enumeration values are not handled correctly
* For a structured value model, switching models leads to losing connections
* When editing entity, the text "Entity should be upper case" appears twice
* On List Characteristic user can choose a datatype or elementCharacteristic but not both
* Filter mode: Case when new connections are displayed after switching between models
* Data type doesn't change when you select another the Characteristic class
@michelu89 michelu89 mentioned this issue Sep 27, 2023
Merged
@michelu89 michelu89 self-assigned this Sep 27, 2023
michelu89 added a commit that referenced this issue Oct 2, 2023
@michelu89 @atextor
Fix/several bugs (#88)
bb7928b 
* Update and fix the documentation

* Fix several bugs

* Increase performance of loading large model #77
* #78
* #69
* Enumeration values are not handled correctly
* For a structured value model, switching models leads to losing connections
* When editing entity, the text "Entity should be upper case" appears twice
* On List Characteristic user can choose a datatype or elementCharacteristic but not both
* Filter mode: Case when new connections are displayed after switching between models
* Data type doesn't change when you select another the characteristic class

---------

Co-authored-by: Andreas Textor <[email protected]>
michelu89 added a commit to bci-oss/esmf-aspect-model-editor that referenced this issue Oct 10, 2023
@michelu89
Add MADR design decision documents
cf792ec 
see eclipse-esmf#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michelu89 michelu89

Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atextor @michelu89 @chris-volk