Fix race condition causing unexpected idle disconnections #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue may appear when 'send[data]' methods are triggered from different threads. As a result threads race appears between cancelIdleTimeoutExecutor and scheduling new idle task. Example of race: 1. Thread 1 cancels task 2. Thread 2 waits until thread 1 will finish 3. Thread 1 finishes 4. Thread 2 tries to cancel already cancelled task and leaves synchronized block 5. Thread 1 schedules new idle task 6. Thread 2 schedules another idle task, the first is overwritten and never cancelled. As a result disconnection is triggered precisely after set idle timeout passes. Signed-off-by: Mykyta Leonov <[email protected]>
|
@jansupol Should I do something additionaly to request review? There is no hurry, but I just want to make sure that this PR won't stuck here for unknown reason. |
|
@rok-povsic FYI, when this is released, dev build version must be replaced by the release (1.21). (Unless something has changed of course). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue may appear when 'send[data]' methods are triggered from different threads. As a result threads race appears between cancelIdleTimeoutExecutor and scheduling new idle task. Example of race:
I would appreciate if this fix will be added to the version responsible for Java 1.x implementation, since this is one we still use in our internal project.