Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove potential test order dependency #725

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

y553546436
Copy link
Contributor

The static EXTENDED_EXTENSION variable is shared among tests. Reinitializing it before the test run can avoid potential test order dependency.

@jansupol
Copy link
Contributor

Please see our wiki

@lprimak
Copy link
Contributor

lprimak commented Feb 7, 2021

Loos good to me

@jansupol
Copy link
Contributor

jansupol commented Apr 1, 2021

As of March-31-2021, the Sign-off-by footer is no longer required. The ECA still is, however. The Author commit header does not seem to be valid.

@y553546436
Copy link
Contributor Author

y553546436 commented Apr 30, 2021

As of March-31-2021, the Sign-off-by footer is no longer required. The ECA still is, however. The Author commit header does not seem to be valid.

Thanks for pointing out. I have signed ECA for the account of the commit.

@y553546436
Copy link
Contributor Author

Hi @jansupol and @lprimak , is there anything I can do on my end for this to be merged? I have changed the commit header and signed ECA.

@lprimak
Copy link
Contributor

lprimak commented Jun 8, 2021

@arjantijms Can you please merge this?
Thank you!

@arjantijms
Copy link
Contributor

@arjantijms Can you please merge this?

Thanks for the ping, it looks good. I'll merge it now.

@arjantijms
Copy link
Contributor

@y553546436 Thanks a lot for your contribution!

@arjantijms arjantijms merged commit e02af53 into eclipse-ee4j:master Aug 23, 2021
@jansupol jansupol added this to the 1.18 milestone Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants