Resolves #365 AutoCloseable jakarta.ws.rs Object instances not being closed after being used. #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! The main branch of Soteria is now btw "main". Still have to set that one to the default. |
…s not being closed after being used.
|
Updated the PRs, FYI the main branch appears to be missing the requirement to have at least one review before merging. |
There's no strict project or process requirement to have a review really. More EE4J / Jakarta projects with lower levels of activity don't have that. You can of course always ask for a review, and then merge it yourself if there's still no review after say a couple of months. |
arjantijms
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#365
FYI most of the lines changes are due to additional indentation after wrapping using try with resources.