Do not overwrite putFields field in accessor

[pzygielo]

• Fixes putFields field gets overwritten for every field #136

[smillidge]

Is there a specific issue this is fixing?

[pzygielo]

Is there a specific issue this is fixing?

There it is

• putFields field gets overwritten for every field #136

This is related to

• De/serialization of ConcurrentHashMap fails #131

but does not resolve it completely. (To be specific, this change does not help with CHM issue at all.)

[pzygielo]

I described the issue for myself first, earlier, and it mentions fields field. But the change is about putFields. I have to re-do my finding and do correction (probably in issue).

[pzygielo]

It was about fields at

orb/orbmain/src/main/java/com/sun/corba/ee/impl/io/OutputStreamHook.java

Line 120 in 08d26c2

Object value = fields.get(osfields[i].getName());

being new, one-element only map, for every new field put to the stream. But due to putFields being overwritten.

[pzygielo]

In SE it is protected on the method level: https://github.com/openjdk/jdk8u/blob/dfa5f14848df6b4b41f839004d6baf37ca2f4f8d/corba/src/share/classes/com/sun/corba/se/impl/io/OutputStreamHook.java#L156-L162

Interesting

• this is how they protected it: openjdk/jdk8u@a8e9ef1
• this is why: https://bugs.openjdk.org/browse/JDK-8068721

[pzygielo]

I believe there are two separate issues here.
I propose to solve them separately.

[pzygielo]

May I ask for review, please?