Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NettyConnectorProvider (jersey-netty-connector) is throwing an except… #4854

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Sep 13, 2021

Relates to #4851

…ion with inactive_pooled_connection_handler error

Signed-off-by: Jorge Bescos Gascon <[email protected]>
} else {
try {
// Remove it only if the channel is open. Otherwise there are no such names and it fails.
chan.pipeline().remove(INACTIVE_POOLED_CONNECTION_HANDLER);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this not to be in else block and try to do this no matter the chan.isOpen or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not very happy about eating one exception, so I tried to minimize the frequency that it happens. But yes, anyway we need to eat it.

}

// This test is for debugging purposes. By default it works with and without the fix.
@Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not in favor of adding this file to the project.

  1. The file brings in additional dependency
  2. The test passes either way. The comment suggests it is for debugging purposes, but the usage is doubtful.

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@senivam senivam merged commit 8fed3c6 into eclipse-ee4j:master Sep 17, 2021
@senivam senivam added this to the 2.36 milestone Sep 17, 2021
This was referenced Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants