-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NettyConnectorProvider (jersey-netty-connector) is throwing an except… #4854
Conversation
…ion with inactive_pooled_connection_handler error Signed-off-by: Jorge Bescos Gascon <[email protected]>
} else { | ||
try { | ||
// Remove it only if the channel is open. Otherwise there are no such names and it fails. | ||
chan.pipeline().remove(INACTIVE_POOLED_CONNECTION_HANDLER); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer this not to be in else
block and try to do this no matter the chan.isOpen
or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not very happy about eating one exception, so I tried to minimize the frequency that it happens. But yes, anyway we need to eat it.
} | ||
|
||
// This test is for debugging purposes. By default it works with and without the fix. | ||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not in favor of adding this file to the project.
- The file brings in additional dependency
- The test passes either way. The comment suggests it is for debugging purposes, but the usage is doubtful.
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Relates to #4851