jersey-2031 #4453
Merged
jersey-2031 #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <[email protected]>
senivam
approved these changes
May 11, 2020
This was referenced Jun 26, 2021
This was referenced Jul 6, 2021
This was referenced Aug 5, 2021
This was referenced Aug 30, 2021
1 task
This was referenced Oct 4, 2021
This was referenced Oct 18, 2021
This was referenced Oct 21, 2021
Merged
Merged
This was referenced Oct 21, 2021
Closed
1 task
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
This was referenced Oct 19, 2022
1 task
1 task
1 task
1 task
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled this module for testing.
The problem is that JDK11 doesn't work with Jetty 6, so we use now Jetty 9.
This brings another problem, for some reason the tld of jersey-mvc-jsp is not loaded. Not sure why, in theory Jetty scans the jar files by regular expression. I tried to add a new regular expression to find jersey-mvc-jsp-2.31-SNAPSHOT.jar but it didn't work:
https://wiki.eclipse.org/Jetty/Howto/Configure_JSP#Using_JSTL_Taglibs_for_Jetty_7.x_and_8.x
Finally I did an ugly solution that works, which is copying the tld in the application. And to make the things more ugly, it doesn't work when you copy the tld in ${project.build.directory}/${project.build.finalName}/WEB-INF. Doing that it includes the TLD in the war file but it is not loaded for some reason.
It needs to be added in src/main/webapp/WEB-INF/ and then removed. It seems Jetty is using as resource folder src/main/webapp