Add new interfaces (PreInvocationInterceptor, PostInvocationInterceptor, and InvocationBuilderListener) documentation #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tvallin <[email protected]>
senivam
approved these changes
Mar 27, 2020
jansupol
requested changes
Mar 27, 2020
docs/src/main/docbook/client.xml
Outdated
| @@ -999,4 +999,139 @@ Client client = ClientBuilder.newBuilder().sslContext(sslContext).build();</prog | |||
|
|
|||
|
|
|||
| </section> | |||
|
|
|||
| <section> | |||
| <title>New Features</title> | |||
There was a problem hiding this comment.
Please do not say it's a new feature. The documentation is there for good, it will be an old feature in a few releases.
docs/src/main/docbook/client.xml
Outdated
| <section> | ||
| <title>New Features</title> | ||
| <para> | ||
| Jersey 2.30 comes with multiple new features, and this post describes three new interfaces on the client. |
There was a problem hiding this comment.
"comes with multiple new features" is not good enough for the documentation. The documentation needs to mention the exact features. Maybe I would create
- Section, InvocationInterceptors:
<para> Suppose a case that the start of the request is to be logged and even measured....</para> - Section InvocationBuilderListener.
These two sections would be on the same level as New Features.
Drop Jersey 2.30 comes... They are... and start with Suppose.
Signed-off-by: tvallin <[email protected]>
jansupol
approved these changes
Mar 27, 2020
senivam
pushed a commit
to senivam/jersey
that referenced
this pull request
Apr 27, 2020
…or, and InvocationBuilderListener) documentation (eclipse-ee4j#4411) * Add new PreInvocationInterceptor, PostInvocationInterceptor, and InvocationBuilderListener interfaces documentation Signed-off-by: tvallin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author/Source: Jan Supol from his blog http://blog.supol.cz/?p=171
Signed-off-by: tvallin [email protected]