Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent HK2 AbstractBinder from being configured twice. #4349

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Prevent HK2 AbstractBinder from being configured twice. #4349

merged 1 commit into from
Dec 17, 2019

Conversation

jansupol
Copy link
Contributor

Revert the change that introduced BinderConfigurationFactory SPI.
Added possibility to register HK2 AbstractBinder class along with the instance option.

Signed-off-by: Jan Supol [email protected]

@jansupol
Prevent HK2 AbstractBinder from being configured twice.
8b14687 
Revert the change that introduced BinderConfigurationFactory SPI.
Added possibility to register HK2 AbstractBinder class along with the instance option.

Signed-off-by: Jan Supol <[email protected]>
@jansupol
Copy link
Contributor Author

Fixes #4256, #4344.

Revert #4122.

@jansupol
Copy link
Contributor Author

Fixes #4111.

Tomas-Kraus
Tomas-Kraus approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@Tomas-Kraus Tomas-Kraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jansupol jansupol merged commit 29913b9 into eclipse-ee4j:master Dec 17, 2019
@jansupol jansupol added this to the 2.30 milestone Dec 18, 2019
@cykl cykl mentioned this pull request Feb 7, 2020
Closed
This was referenced Jun 26, 2021
Merged
Open
Open
Merged
Open
This was referenced Aug 5, 2021
Closed
Closed
This was referenced Aug 30, 2021
Closed
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Sep 6, 2021
Merged
1 task
This was referenced Oct 4, 2021
Merged
Merged
This was referenced Oct 18, 2021
Open
Open
This was referenced Oct 21, 2021
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 21, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@renovate renovate bot mentioned this pull request Jan 10, 2022
Open
1 task
@mend-for-github.aaakk.us.kg mend-for-github.aaakk.us.kg bot mentioned this pull request Feb 5, 2022
Closed
1 task
This was referenced Mar 7, 2022
Closed
Closed
This was referenced Mar 15, 2022
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@mend-for-github.aaakk.us.kg mend-for-github.aaakk.us.kg bot mentioned this pull request May 12, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
This was referenced Oct 19, 2022
Closed
Closed
@mend-for-github.aaakk.us.kg mend-for-github.aaakk.us.kg bot mentioned this pull request Dec 5, 2022
Open
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
@renovate renovate bot mentioned this pull request May 11, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Jul 6, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Aug 30, 2023
Merged
1 task
@mend-for-github.aaakk.us.kg mend-for-github.aaakk.us.kg bot mentioned this pull request Dec 4, 2023
Open
@mend-for-github.aaakk.us.kg mend-for-github.aaakk.us.kg bot mentioned this pull request Jan 11, 2024
Open
@renovate renovate bot mentioned this pull request Apr 19, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomas-Kraus Tomas-Kraus Tomas-Kraus approved these changes

@senivam senivam senivam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.30
Development

Successfully merging this pull request may close these issues.
3 participants
@jansupol @senivam @Tomas-Kraus