xjc:javaType does not handle generic types

[Tomas-Kraus]

When the type being mapped to is generic, xjc does not strip generics off of the
import statement.

Example:

xmlns:xjc="http://java.sun.com/xml/ns/jaxb/xjc"
<xjc:javaType adapter="ListAdapter" name="java.util.List" />

generates to

1. 1. 1. 1. 1. 1. Output #####

import java.util.List; // <-- Problem
import javax.xml.bind.annotation.XmlAccessType;
*
*
*
@xmlelement(type = String.class)
@XmlJavaTypeAdapter(ListAdapter.class)
protected Listitems;
*
*
*

If you try with java.util.List, it will work but will have raw type warnings.

However, this is not as simple as stripping out the generics. Its entirely
possible that it could be a list of some custom element, and thus that custom
element needs to be imported as well. It could also be a Map, and thus have
multiple generic parameters, or a list of maps, so the solution needs to handle
that. (Ex: Map<String, Map<String, List<String, OtherType<String, Map<String,
String>, String>>>> ..)

I wrote up a fix Someone just needs to figure out where it needs to go,
refactor it to fit JAXB coding conventions, and possibly add some sensible error
messages that can be passed to the user.

final Set imports = new TreeSet();
final Matcher typeMatcher = Pattern.compile("[^<>,
p

{Blank}

]+").matcher(name);
final StringBuffer sb = new StringBuffer();
while (typeMatcher.find()) {
final String qualifiedType = typeMatcher.group().trim();
if (qualifiedType.isEmpty())

{ break; }

final int endIndex = qualifiedType.lastIndexOf(".");
if (endIndex < 0)

{ typeMatcher.appendReplacement(sb, qualifiedType); }

else

{ imports.add(qualifiedType); // Might want to do error checking ("name = java.util.") final String type = qualifiedType.substring(endIndex + 1); typeMatcher.appendReplacement(sb, type); }

}
typeMatcher.appendTail(sb);
final String javaType = sb.toString();

Environment

Operating System: All
Platform: All

Affected Versions

[2.1.12]

[Tomas-Kraus]

@glassfishrobot Commented
Reported by royalpeasantry

[Tomas-Kraus]

@glassfishrobot Commented
Was assigned to snajper

[Tomas-Kraus]

@glassfishrobot Commented
royalpeasantry said:
This should be platform independent.

[Tomas-Kraus]

@glassfishrobot Commented
snajper said:
assigning

[Tomas-Kraus]

@glassfishrobot Commented
This issue was imported from java.net JIRA JAXB-737

[Tomas-Kraus]

• Issue Imported From: xjc:javaType does not handle generic types javaee/jaxb-v2#737
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @glassfishrobot

[laurentschoelens]

@lukasj : found a way to fix this, will provide PR