Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occurrence constants are misspelled #40

Closed
raner opened this issue Oct 1, 2022 · 0 comments · Fixed by #46
Closed

Occurrence constants are misspelled #40

raner opened this issue Oct 1, 2022 · 0 comments · Fixed by #46

Comments

@raner
Copy link

raner commented Oct 1, 2022

The constants for occurrence constraints are all missing a second r. As these constants are already part of public API and cannot be changed without breaking backwards compatibility, it's probably best to deprecate the misspelled ones and add new ones with proper spelling and the same values:

+   public final short OCCURRENCE_ZERO_OR_MORE = 0;
+
+   @Deprecated
    public final short OCCURENCE_ZERO_OR_MORE = 0;
+
+   public final short OCCURRENCE_ONE_OR_MORE = 1;
+
+   @Deprecated
    public final short OCCURENCE_ONE_OR_MORE = 1;
+
+   public final short OCCURRENCE_ZERO_OR_ONE = 2;
+
+   @Deprecated
    public final short OCCURENCE_ZERO_OR_ONE = 2;
+
+   public final short OCCURRENCE_ONCE = 3;
+
+   @Deprecated
    public final short OCCURENCE_ONCE = 3;
lukasj added a commit to lukasj/jaxb-dtd-parser that referenced this issue Oct 19, 2023
lukasj added a commit that referenced this issue Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant