The common-util: Fixed dependencies on default charset #25119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Aug 26, 2024
dmatej
commented
- The asenv.conf file must be UTF-8 by default - it is provided by us.
- Property files are Latin1 aka ISO-8859-1 by default.
- ProcessStreamDrainerWorker still uses default charset but was formatted.
- XmlParserHelper was not used so I deleted it
- FileUtils
- Explicit usage of GC allowed here
- Fixed dependencies on system default charset - added parameter
- However line endings are still taken from system; it is ok for all actual usages (PEM file allows CRLF, CR, LF, pid file doesn't have line ending) and I added that to javadoc.
- PayloadImpl now converts string to utf8 byte array, not system default charset
- ServerDirs - local paswordfile is UTF-8 encoded, not system default charset
- SSHUtil - PEM files use Latin1 and all types of line endings are allowed.
- AsadminInput - still use system defaut charset. Controversial.
- FileRealmHelper - Using UTF-8
- The asenv.conf file must be UTF-8 by default - it is provided by us.
- Property files are Latin1 aka ISO-8859-1 by default.
- ProcessStreamDrainerWorker still uses default charset but was formatted.
- XmlParserHelper was not used so I deleted it
- FileUtils
- Explicit usage of GC allowed here
- Fixed dependencies on system default charset - added parameter
- However line endings are still taken from system; it is ok for all actual
usages (PEM file allows CRLF, CR, LF, pid file doesn't have line ending)
and I added that to javadoc.
- PayloadImpl now converts string to utf8 byte array, not system default charset
- ServerDirs - local paswordfile is UTF-8 encoded, not system default charset
- SSHUtil - PEM files use Latin1 and all types of line endings are allowed.
- AsadminInput - still use system defaut charset. Controversial.
- FileRealmHelper - Using UTF-8
Signed-off-by: David Matějček <[email protected]>
dmatej
force-pushed
the
common-util-vs-spotbugs
branch
from
540bd11 to
66d95bc
Compare
avpinchuk
approved these changes
Aug 27, 2024
hs536
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.