Fix the startserv script if server is already running #25027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also report the error immediately, don't run the command again Adds tests for the startserv script. For that, improves the process manager to allow waiting until a text it output instead of waiting for the process to complete.
dmatej
reviewed
Jul 13, 2024
| ProcessManager pm = new ProcessManager("sh", "-c", "echo \"start\nhello\ncontinue\""); | ||
| pm.setEcho(false); | ||
| pm.setTextToWaitFor("hello"); | ||
| int exitCode = assertDoesNotThrow(pm::execute); | ||
| Thread.sleep(ofSeconds(1)); | ||
| Thread.sleep(sleepTimeSeconds * 1000); |
There was a problem hiding this comment.
You can write also 1_000L, no need to create a variable if it doesn't have any other usage.
There was a problem hiding this comment.
I wanted to do that first, but then I saw that other test method follow this pattern so I did it this way. If we used Java 21, I would rather use Duration, but with millis I’m not sure which approach is better.
dmatej
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also report the error immediately, don't run the command again
Adds tests for the startserv script. For that, improves the process manager to allow waiting until a text it output instead of waiting for the process to complete.