Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Parsson 1.1.7 #25017

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

avpinchuk
Copy link
Contributor

Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk
Copy link
Contributor Author

Partially fixes #25009. Fixes stack traces in server.log related to JSON Processing.

@avpinchuk
Copy link
Contributor Author

Standalone JSON-P and JSON-P Pluggability TCKs passed.

@avpinchuk avpinchuk added the ee10-component Jakarta EE 10 component label Jul 1, 2024
@avpinchuk avpinchuk added this to the 7.0.16 milestone Jul 1, 2024
@avpinchuk avpinchuk self-assigned this Jul 1, 2024
@arjantijms
Copy link
Contributor

If I'm not mistaken parson updates cause failures in the REST TCK, at least that was the reason to revert last time.

We should look at why that TCK fails after this update.

@avpinchuk avpinchuk marked this pull request as draft July 1, 2024 22:37
@avpinchuk
Copy link
Contributor Author

If I'm not mistaken parson updates cause failures in the REST TCK, at least that was the reason to revert last time.

We should look at why that TCK fails after this update.

Thank you! I'll take a look.

@avpinchuk
Copy link
Contributor Author

avpinchuk commented Jul 1, 2024

@arjantijms, local REST TCK passed. Did we revert Parsson and not Yasson?

UPD: e305bb2

@avpinchuk avpinchuk marked this pull request as ready for review July 1, 2024 23:01
@arjantijms
Copy link
Contributor

@arjantijms, local REST TCK passed. Did we revert Parsson and not Yasson?

UPD: e305bb2

Indeed, Yasson 3.0.4 seemed problematic.

@arjantijms arjantijms merged commit e7ea19e into eclipse-ee4j:master Jul 2, 2024
2 checks passed
@avpinchuk avpinchuk deleted the parsson_1_1_7 branch July 2, 2024 10:50
@avpinchuk
Copy link
Contributor Author

avpinchuk commented Jul 4, 2024

Indeed, Yasson 3.0.4 seemed problematic.

@arjantijms, REST TCK passed on JDK 17, but failed on JDK 11.

Yasson 3.0.3 was compiled with target=11, whereas Yasson 3.0.4 was compiled with target=17.

Also Yasson 3.0.4 contains methods that are missing in Java 11 (e.g., Class.isRecord()). In Yasson 3.0.3 these methods where located in MR-JAR folder for Java 16, in Yasson 3.0.4 - under default (non-MR) path.

Whereas minimal JDK version to run GlassFish 7 is 11.

@pzygielo
Copy link
Contributor

pzygielo commented Jul 5, 2024

@m0mus @Verdent - can you re-do yasson 3.0.4 and replace staged version?

@arjantijms
Copy link
Contributor

In Yasson 3.0.3 these methods where located in MR-JAR folder for Java 16, in Yasson 3.0.4 - under default (non-MR) path.

Thanks for finding the root cause of the failure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ee10-component Jakarta EE 10 component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants