Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CDI TCK #24929

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Refactor CDI TCK #24929

merged 8 commits into from
Apr 23, 2024

Conversation

avpinchuk
Copy link
Contributor

@avpinchuk avpinchuk commented Apr 21, 2024 •
edited
Loading

What is done:

  • Organized dependencies to reduce the impact of transitive dependencies.
  • Used JUnit5 instead of JUnit4 in CDI Lang Model TCK.
  • Replaced obsoleted forkMode Maven parameter.
  • Used consistent profiles naming in all CDI TCKs.
  • Moved CDI Signature TCK to the separate module.
  • Fixed CDI Full TCK test report generation.

@avpinchuk
Update and organize dependencies
f1fb359 
Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk
Update CDI Lang Model TCK to JUnit5
122ddd1 
Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk
Replace obsoleted forkMode parameter
6f02c07 
Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk
Add missing test scope for the Arquillian connectors
713bfe4 
Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk
Use consistent profile naming
705e233 
Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk
Move CDI Signature TCK to separate module
7e85e25 
Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk
Excludes forgotten dependencies
916f033 
Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk
Fixes test report generation
0e49d92 
Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk avpinchuk added this to the 7.0.15 milestone Apr 22, 2024
@avpinchuk avpinchuk self-assigned this Apr 22, 2024
@avpinchuk
Copy link
Contributor Author

How to run CDI TCKs:

  • All tests at once:

    • Full Profile: mvn clean install -amd -fae -Ptck -pl :glassfish-external-tck-cdi-parent
    • Web Profile: mvn clean install -amd -fae -Ptck,web -pl :glassfish-external-tck-cdi-parent

  • Separate tests:

    • CDI Full TCK:
      • Full Profile: mvn clean install -Ptck -pl :glassfish-external-tck-cdi
      • Web Profile: mvn clean install -Ptck,web -pl :glassfish-external-tck-cdi
    • CDI Lang Model TCK:
      • Full Profile: mvn clean install -Ptck -pl :glassfish-external-tck-cdi-model
      • Web Profile: mvn clean install -Ptck,web -pl :glassfish-external-tck-cdi-model
    • CDI Signature TCK:
      • Full Profile: mvn clean install -Ptck -pl :glassfish-external-tck-cdi-signature
      • Web Profile: mvn clean install -Ptck,web -pl :glassfish-external-tck-cdi-signature

@avpinchuk avpinchuk marked this pull request as ready for review April 22, 2024 18:58
@dmatej dmatej merged commit d006d77 into eclipse-ee4j:master Apr 23, 2024
2 checks passed
@avpinchuk avpinchuk deleted the refactor-cdi-tck branch April 23, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmatej dmatej dmatej approved these changes

@hs536 hs536 hs536 approved these changes

@arjantijms arjantijms Awaiting requested review from arjantijms

@pzygielo pzygielo Awaiting requested review from pzygielo

Assignees

@avpinchuk avpinchuk

Labels
build and test improvement code cleaning
Projects
None yet
Milestone
7.0.15
Development

Successfully merging this pull request may close these issues.
3 participants
@avpinchuk @dmatej @hs536