Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes GlassFish event filtering #24796

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fixes GlassFish event filtering #24796

merged 1 commit into from
Feb 9, 2024

Conversation

avpinchuk
Copy link
Contributor

Event filtering with RestrictTo annotation does not works.

@avpinchuk
Fixes event filtering
c39b560 
Signed-off-by: Alexander Pinčuk <[email protected]>
@avpinchuk
Copy link
Contributor Author

License header not fixed yet. I'll do refactoring of the evens processing code in next PR.

@avpinchuk avpinchuk added the bug Something isn't working label Feb 9, 2024
@avpinchuk avpinchuk added this to the 7.0.13 milestone Feb 9, 2024
@avpinchuk avpinchuk self-assigned this Feb 9, 2024
@avpinchuk avpinchuk marked this pull request as ready for review February 9, 2024 09:04
pzygielo
pzygielo approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@pzygielo pzygielo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given @Target of

glassfish/nucleus/common/glassfish-api/src/main/java/org/glassfish/api/event/RestrictTo.java

Lines 39 to 41 in 6611a36

@Target(ElementType.PARAMETER)
@Retention(RetentionPolicy.RUNTIME)
public @interface RestrictTo {
it seems correct to inspect the parameter itself rather than its type indeed.

@dmatej dmatej merged commit 12eb0f8 into eclipse-ee4j:master Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzygielo pzygielo pzygielo approved these changes

@dmatej dmatej dmatej approved these changes

@arjantijms arjantijms Awaiting requested review from arjantijms

@hs536 hs536 Awaiting requested review from hs536

Assignees

@avpinchuk avpinchuk

Labels
bug Something isn't working
Projects
None yet
Milestone
7.0.13
Development

Successfully merging this pull request may close these issues.
3 participants
@avpinchuk @dmatej @pzygielo